[stdlib] Move tuple.mojo off unroll
#3055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abduld
reviewed
Jun 16, 2024
Signed-off-by: Yiwu Chen <[email protected]>
soraros
force-pushed
the
remove-unroll-tuple
branch
from
aa549a2
to
8e77e1b
Compare
JoeLoser
approved these changes
Jun 20, 2024
|
!sync |
modularbot
added
the
imported-internally
|
This is hitting a compiler crash — I just filed a bug internally for this. |
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
JoeLoser
removed
the
blocked
modularbot
pushed a commit
that referenced
this pull request
Jun 27, 2024
[External] [stdlib] Move `tuple.mojo` off `unroll` Remove the use of the `unroll` function from `tuple.mojo` in favour of `@parameter if`. Co-authored-by: soraros <[email protected]> Closes #3055 MODULAR_ORIG_COMMIT_REV_ID: baea5b29de0ece95a79023028832195891fd3af8
|
Landed in 4e76e84! Thank you for your contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of the
unrollfunction fromtuple.mojoin favour of@parameter if.