Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] List's __getref() uses normalize_index() #3031

Open
wants to merge 1 commit into
base: nightly
Choose a base branch
from
Open

[stdlib] List's __getref() uses normalize_index() #3031

wants to merge 1 commit into from
+2 −4

Conversation

MatveyF
Copy link

@MatveyF MatveyF commented Jun 12, 2024

Using normalize_index() in List's __getref() to reduce boilerplate bounds checking.

Note:
Initially opened #3024 but due to a bug was asked to open separate PRs for each method.

@MatveyF MatveyF requested a review from a team as a code owner June 12, 2024 18:08
@ConnorGray
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldemarmiesse gabrieldemarmiesse gabrieldemarmiesse approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@ConnorGray ConnorGray

Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MatveyF @ConnorGray @gabrieldemarmiesse @modularbot