Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#5200: Use squeeze parameter instead of SeriesGroupby #5201

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

devin-petersohn
Copy link
Collaborator

@devin-petersohn devin-petersohn commented Nov 7, 2022

Signed-off-by: Devin Petersohn [email protected]

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: Dataframe.groupby.__getitem__ does not properly support single column #5200
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@devin-petersohn devin-petersohn requested a review from a team as a code owner November 7, 2022 16:25
@mvashishtha
Copy link
Collaborator

@devin-petersohn could you please address the CI failures and also add a test case for this?

Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Dataframe.groupby.__getitem__ does not properly support single column
2 participants