-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agent server management functions #239
Open
pan-x-c
wants to merge
25
commits into
modelscope:main
Choose a base branch
from
pan-x-c:feature/pxc/agent_server_enhance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add agent server management functions #239
pan-x-c
wants to merge
25
commits into
modelscope:main
from
pan-x-c:feature/pxc/agent_server_enhance
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbc2016
reviewed
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the old version, the rpc agent server only has a
call_func
method, and all agents' own methods and agent server management related methods need to be implemented through thecall_func
, making this method bloated.This PR adds a series of agent server management functions (used to support agent server management modules), and extracts management related methods from the original
call_func
interface.All agent server management functions are listed below:
is_alive
: whether the server is alivestop
: stop the servercreate_agent
: create a new agent on the serverdelete_agent
: delete agents from the serverclone_agent
: clone an agent with specific agent_idget_agent_id_list
: get agent_id of all agents on the server as a listget_agent_info
: get the agent information of the specific agent_idget_server_info
: get the resource utilization information of the serverset_model_configs
: update the model configs of the serverget_agent_memory
: get the memory of a specific agent on the serverdownload_file
: download a file from the serverThe original
call_func
is renamed tocall_agent_func
, and only handle method calls of the agent itself.The placeholder update method is also extracted from the original
call_func
method as a separateupdate_placeholder
method.This PR makes the rpc messages used by each method more compact. Tests show that it can reduce the running time of large-scale simulation example by 5 - 10%.
Unittests and tutorials have been updated accordingly.
Checklist
Please check the following items before code is ready to be reviewed.