Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Deep copy ImportTask.segmentsInfo to prevent data race (#34090) #34126

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #34090
See also #34089

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/S Denotes a PR that changes 10-29 lines. labels Jun 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (1168e8c) to head (727dc3e).
Report is 9 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34126      +/-   ##
==========================================
- Coverage   81.83%   81.78%   -0.06%     
==========================================
  Files        1005     1013       +8     
  Lines      130111   129934     -177     
==========================================
- Hits       106479   106266     -213     
- Misses      19644    19670      +26     
- Partials     3988     3998      +10     
Files Coverage Δ
internal/datanode/importv2/task_import.go 86.50% <100.00%> (+0.32%) ⬆️
internal/datanode/importv2/task_l0_import.go 78.68% <100.00%> (+0.53%) ⬆️
internal/datanode/importv2/task_l0_preimport.go 84.31% <100.00%> (ø)
internal/datanode/importv2/task_preimport.go 91.45% <100.00%> (ø)

... and 219 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@mergify mergify bot removed the ci-passed label Jun 26, 2024
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jun 26, 2024
@sre-ci-robot sre-ci-robot merged commit 3cf526e into milvus-io:2.4 Jun 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants