Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Avoid search querynode return nil status in response #34100

Merged

Conversation

weiliu1031
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 24, 2024
Copy link
Contributor

mergify bot commented Jun 24, 2024

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify mergify bot added the ci-passed label Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.79%. Comparing base (a1248a1) to head (133270e).
Report is 23 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #34100   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files        1080     1080           
  Lines      137018   137005   -13     
=======================================
- Hits       110704   110694   -10     
- Misses      22086    22089    +3     
+ Partials     4228     4222    -6     
Files Coverage Δ
internal/querynodev2/services.go 91.73% <100.00%> (+<0.01%) ⬆️

... and 23 files with indirect coverage changes

@weiliu1031
Copy link
Contributor Author

@mergify refresh

Copy link
Contributor

mergify bot commented Jun 26, 2024

refresh

✅ Pull request refreshed

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jun 26, 2024
@sre-ci-robot sre-ci-robot merged commit 4520342 into milvus-io:master Jun 26, 2024
14 of 15 checks passed
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants