Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't show output items if they are empty #216844

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

don't show output items if they are empty #216844

wants to merge 10 commits into from
+253 −38

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Jun 21, 2024 •
edited
Loading

@amunger
Copy link
Contributor Author

amunger commented Jun 21, 2024

checking the innerText === '' doesn't really make sense since all plots/images have empty inner text.
checking if the element has any height would work, except that the children of the element are padded and therefore always have a significant height.

@amunger amunger requested a review from rebornix June 28, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebornix rebornix Awaiting requested review from rebornix

At least 1 approving review is required to merge this pull request.

Assignees

@amunger amunger

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@amunger