Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Close to the Left command to right click context menu #215952

Conversation

henrikvilhelmberglund
Copy link

This PR adds a Close to the Left command below the existing Close to the Right command in the context menu shown when right clicking on a tab.

I find myself wanting to use this command a lot since opening new files makes them appear to the right and I want to close the old tabs while still keeping the new tabs to the right.

The command was added below the Close to the Right to not mess with muscle memory of people already using Close to the Right.

Before:
before

After:
after

Feel free to edit.

@benibenj
Copy link
Contributor

benibenj commented Jun 26, 2024

We are not planning on adding new actions to the context menus of tabs. There already a lot and we do not want to clutter that menu. We already support the workbench.action.closeEditorsToTheLeft command for which you can set a key binding or call from the command palette. We also newly support multi selecting tabs. This would allow you to select tabs with shift + click and run the close (ctrl+w) or close others action.

@benibenj benibenj closed this Jun 26, 2024
@henrikvilhelmberglund
Copy link
Author

We are not planning on adding new actions to the context menus of tabs. There already a lot and we do not want to clutter that menu. We already support the workbench.action.closeEditorsToTheLeft command for which you can set a key binding or call from the command palette. We also newly support multi selecting tabs. This would allow you to select tabs with shift + click and run the close (ctrl+w) or close others action.

Are there any plans for adding customizability for context menus then? It seems a bit silly that clutter is mentioned as a reason when I have never used half of the commands in the context menu.

@gjsjohnmurray
Copy link
Contributor

Are there any plans for adding customizability for context menus then?

This is a longstanding request - #9285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants