intellisense for code actions on save #215475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #161284
related #212381
issue: no intellisense because of how we get contributed or default code actions on save
https://github.com/justschen/vscode/blob/a6bda062d6a861071758ded8abc781af37a083e2/src/vs/workbench/contrib/codeActions/common/codeActionsExtensionPoint.ts#L69
atm, we only search contributions if they statically contribute
code actions
(ie, https://github.com/justschen/vscode/blob/a6bda062d6a861071758ded8abc781af37a083e2/extensions/typescript-language-features/package.json#L1608-L1609)this allows us to gather ALL code actions that are contributed, sorts by source actions, dynamically adds
demo with ruff and eslint installed:
![Screenshot 2024-06-13 at 2 35 09 PM](https://private-user-images.githubusercontent.com/54879025/339560558-da0bdde5-598a-446c-92b4-60c9061fd071.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNTgxMTYsIm5iZiI6MTcxOTM1NzgxNiwicGF0aCI6Ii81NDg3OTAyNS8zMzk1NjA1NTgtZGEwYmRkZTUtNTk4YS00NDZjLTkyYjQtNjBjOTA2MWZkMDcxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI1VDIzMjMzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY2OWEzMzJhOWI4MGY0NzllZTFhYWRjOTM2ZTQ5MDZjZWYwNGY5NTYyMTdjYTc4NzA2ODQ2YjZjYzdkMzYzYjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.WKlNtxPqzYcod_XaYyeXYvSM1J6HuQxhNPq_IEF7DAo)
![Screenshot 2024-06-13 at 2 34 54 PM](https://private-user-images.githubusercontent.com/54879025/339560569-6dfd9fda-d9cf-4a55-a6ba-67e64b5f7832.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNTgxMTYsIm5iZiI6MTcxOTM1NzgxNiwicGF0aCI6Ii81NDg3OTAyNS8zMzk1NjA1NjktNmRmZDlmZGEtZDljZi00YTU1LWE2YmEtNjdlNjRiNWY3ODMyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI1VDIzMjMzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUzYjkyMGE2ODRjZTIzY2FiZWJmM2M5NzFkYTE5OGZkODMxNjM3MGY3MDE0YWRkYTU0YjcwM2Y1MGVhOTc2MGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.z6l_Ffo8lafMB63Br2KS26HdWiNLMTgNExXz2hXk8Us)
cc. @Yoyokrazy