Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle more than 2 statusBarCommands (fix #214918) #214978

Closed
wants to merge 1 commit into from

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes #214918

See issue for example that can be used for verification.

Copy link
Contributor Author

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @lszomoru

@gjsjohnmurray gjsjohnmurray changed the title Handle more that 2 statusBarCommands (fix #214918) Handle more than 2 statusBarCommands (fix #214918) Jun 12, 2024
@lszomoru
Copy link
Member

Thank you very much for the fix. While your change does seemingly fix the issue, there is an underlying issue in the Statusbar widget as it was not supporting groups with more than 2 items. I am closing this issue in favor of a fix at the Statusbar level - #216605.

@lszomoru lszomoru closed this Jun 19, 2024
@gjsjohnmurray gjsjohnmurray deleted the fix-214918 branch June 23, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SourceControl.statusBarCommands - third and subsequent commands are detached from first two
2 participants