Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure any status bar item created by extension has meaningful id #214959

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make sure any status bar item created by extension has meaningful id #214959

wants to merge 3 commits into from
+2 −2

Commits on Jun 12, 2024

  1. Make sure any status bar item created by extension has meaningful id 

    If an extension does not specify the id of the status bar item, it still makes sense to generate the identifier that includes extension id.
Otherwise, in case of multiple extension hosts, it is possibile that during the initialization, different extension hosts may generate the same sequential id and one of the status bar items will not be visible.
    @irengrig
    irengrig committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    fa06dc7 View commit details
    Browse the repository at this point in the history

  2. Change the fix to comply with the comment in the public API

    @irengrig
    irengrig committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    e85b426 View commit details
    Browse the repository at this point in the history

  3. Update extHostStatusBar.ts

    @irengrig
    irengrig committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    aa9ed7b View commit details
    Browse the repository at this point in the history