Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SourceControl.statusBarCommands - third and subsequent commands are detached from first two #214918

Closed
gjsjohnmurray opened this issue Jun 11, 2024 · 1 comment · Fixed by #216605
Closed

SourceControl.statusBarCommands - third and subsequent commands are detached from first two #214918

gjsjohnmurray opened this issue Jun 11, 2024 · 1 comment · Fixed by #216605
Assignees
@lszomoru
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues
Milestone
June 2024

Comments

@gjsjohnmurray
Copy link
Contributor

gjsjohnmurray commented Jun 11, 2024 •
edited
Loading

Type: Bug

  1. Have an SCM extension that adds more that 2 status bar commands.
  2. Observe that the 3rd and subsequent ones aren't adjacent to the first two.

image

Clone https://github.com/gjsjohnmurray/vscode-extension-samples/tree/show-vscode-214918 for the example shown in the screenshot above.

VS Code version: Code - Insiders 1.91.0-insider (21decd9, 2024-06-11T06:46:21.055Z)
OS version: Windows_NT x64 10.0.22631
Modes:
gjsjohnmurray added a commit to gjsjohnmurray/vscode-extension-samples that referenced this issue Jun 11, 2024
@gjsjohnmurray
Demonstrate microsoft/vscode#214918
739deeb
@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues labels Jun 12, 2024
@lszomoru lszomoru added this to the June 2024 milestone Jun 12, 2024
@gjsjohnmurray
Copy link
Contributor Author

I think the fix probably needs to be here:

vscode/src/vs/workbench/contrib/scm/browser/activity.ts

Lines 224 to 227 in 51d5981

store.add(index === 0 ?
this.statusbarService.addEntry(statusbarEntry, `status.scm.${index}`, MainThreadStatusBarAlignment.LEFT, 10000) :
this.statusbarService.addEntry(statusbarEntry, `status.scm.${index}`, MainThreadStatusBarAlignment.LEFT, { id: `status.scm.${index - 1}`, alignment: MainThreadStatusBarAlignment.RIGHT, compact: true })
);

gjsjohnmurray added a commit to gjsjohnmurray/vscode that referenced this issue Jun 12, 2024
@gjsjohnmurray
Handle more that 2 statusBarCommands (fix microsoft#214918)
b50cf5e
@gjsjohnmurray gjsjohnmurray mentioned this issue Jun 12, 2024
Closed
@lszomoru lszomoru mentioned this issue Jun 19, 2024
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lszomoru lszomoru

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues
Projects
None yet
Milestone
June 2024
3 participants
@lszomoru @gjsjohnmurray @VSCodeTriageBot