[opencv] update to 4.9 #38928
[opencv] update to 4.9 #38928
Conversation
JonLiu1993
added
the
category:port-update
| -DWITH_DSHOW=${WITH_DSHOW} | ||
| -DBUILD_opencv_calib3d=${BUILD_opencv_calib3d} | ||
| -DBUILD_opencv_highgui=${BUILD_opencv_highgui} | ||
| ${ADDITIONAL_BUILD_FLAGS} |
There was a problem hiding this comment.
Please also fix python installation behavior.
I needed to add:
-D__INSTALL_PATH_PYTHON3=${CURRENT_PACKAGES_DIR}/${PYTHON3_SITE}/cv2
and for cleanup later:
file(GLOB python_dir LIST_DIRECTORIES true RELATIVE "${CURRENT_PACKAGES_DIR}/lib/" "${CURRENT_PACKAGES_DIR}/lib/python*")
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/lib/${python_dir}/site-packages/cv2/typing")
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/lib/${python_dir}/site-packages/cv2/typing")
However if the install logs show that python bindings get installed into the right directory already than consider this obsolete.
| @@ -380,12 +383,16 @@ endif() | |||
| vcpkg_cmake_configure( | |||
There was a problem hiding this comment.
I feel like there are way to many options here which should and are already be controlled by vcpkg_check_features
-DBUILD_WEBP=OFF
-DBUILD_ZLIB=OFF
-DBUILD_TBB=OFF
-DWITH_OPENVINO=${WITH_OPENVINO}
-DWITH_TBB=${WITH_TBB}
-DWITH_OPENJPEG=OFF
etc.
There was a problem hiding this comment.
some with options are more complex than what might be handled by vcpkg_check_features and so they are handled outside of it
There was a problem hiding this comment.
I misread some of the options since they are so similar. BUILD_ prefix probably means to build those so those should be correctly off but the WITH_ options all look like they should be handled with vcpkg_check_features if all they want is OFF/ON
There was a problem hiding this comment.
the combination to decide on/off is not just user based but depends on the target architecture/os...
There was a problem hiding this comment.
the combination to decide on/off is not just user based but depends on the target architecture/os...
That is controlled by designing the features accordingly with support statements or making them default features + platform expression. In general you don't need to have os/arch based logic if vcpkg_check_features is enough to pass the flag. The ON/OFF selection can be done via designing the manifest accordingly.
There was a problem hiding this comment.
ok I am leaving all your suggestions as open comments to remind them. Right now my first goal is to have it green flagged in ci, then I will do these "cosmetic" fixes
…nto dev/cenit/opencv49
|
i want to close here quickly because then there is already opencv 4.10 to be added! |
cenit
force-pushed
the
dev/cenit/opencv49
branch
2 times, most recently
from
4290c30
to
4f083e7
Compare
update feature matrix, lapack was enabled without notice without this further variable, remove cmake target, win32ui not available for uwp, add fixme tags, remove gtk feature from default, update reference
cenit
force-pushed
the
dev/cenit/opencv49
branch
from
acb1a21
to
68b960e
Compare
|
opencv and opencv4 are marked as passing on the remaining "failing tests" but vcpkg-ci-opencv is marked as failing without even testing. What am i missing? |
Fixes #36009
Fixes #39224
Fixes #39454
Fixes #38321
Fixes #36771
Fixes #36093
Fixes #35937
Fixes #34559
Fixes #34279
Fixes #33742
Fixes #32228
Fixes #17850
Fixes #13120
Fixes #4937
./vcpkg x-add-version --alland committing the result.