Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: VectorStore: Add unit tests for mappers and adding dedicated options for mapper. #6948

Conversation

westey-m
Copy link
Contributor

Motivation and Context

As part of adding new vector stores for redis and qdrant, these include mappers from data models to storage models and back, that require unit testing.
The mapper interface also uses an options parameter which was reused from the IVectorRecordStore.GetAsync method, but really should have been a dedicated options object from the start.

Description

  • Added unit tests for the redis and qdrant data model mappers.
  • Added a dedicated options model for the mapper.

Contribution Checklist

@westey-m westey-m requested a review from a team as a code owner June 25, 2024 16:14
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core memory labels Jun 25, 2024
@github-actions github-actions bot changed the title VectorStore: Add unit tests for mappers and adding dedicated options for mapper. .Net: VectorStore: Add unit tests for mappers and adding dedicated options for mapper. Jun 25, 2024
@westey-m westey-m merged commit f175b45 into microsoft:feature-memory-service Jun 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel.core kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants