Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sys sxit when show pfs status #3417

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Remove sys sxit when show pfs status #3417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d9a4cd
update
Jun 14, 2024
add3b9e
Merge branch 'main' into dev/chenyin_remove_sys_exit
YingChen1996 Jun 17, 2024
7698cc8
Merge branch 'main' into dev/chenyin_remove_sys_exit
YingChen1996 Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/promptflow-devkit/promptflow/_cli/_pf/_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,4 +342,3 @@ def show_service():
f"Prompt flow service is not started. The prompt flow service log is located at {log_file.as_posix()} "
f"and prompt flow version is {get_pfs_version()}."
)
sys.exit(1)
3 changes: 1 addition & 2 deletions src/promptflow-devkit/tests/sdk_pfs_test/e2etests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,5 +70,4 @@ def test_start_service(self, capsys):
finally:
port = get_port_from_config()
kill_exist_service(port=port)
with pytest.raises(SystemExit):
self._run_pfs_command("status")
self._run_pfs_command("status")
Loading