Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prompty] AsyncFlow.load on prompty should return AsyncPrompty #3414

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

lalala123123
Copy link
Contributor

Description

obj = AsyncFlow.load(source="path/to/prompty.prompty")

obj type should be AsyncPrompty.

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@lalala123123 lalala123123 requested a review from a team as a code owner June 14, 2024 03:52
Copy link

github-actions bot commented Jun 14, 2024

promptflow SDK CLI Azure E2E Test Result zhrua/fix_async_prompty

  4 files    4 suites   4m 18s ⏱️
243 tests 203 ✅  40 💤 0 ❌
972 runs  812 ✅ 160 💤 0 ❌

Results for commit 1325ac1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 14, 2024

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 1325ac1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 14, 2024

SDK CLI Global Config Test Result zhrua/fix_async_prompty

6 tests   6 ✅  1m 17s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 1325ac1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 14, 2024

Executor Unit Test Result zhrua/fix_async_prompty

796 tests   796 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 1325ac1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 14, 2024

Executor E2E Test Result zhrua/fix_async_prompty

246 tests   240 ✅  5m 3s ⏱️
  1 suites    6 💤
  1 files      0 ❌

Results for commit 1325ac1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 14, 2024

SDK CLI Test Result zhrua/fix_async_prompty

    4 files      4 suites   1h 5m 58s ⏱️
  786 tests   763 ✅ 23 💤 0 ❌
3 144 runs  3 052 ✅ 92 💤 0 ❌

Results for commit 1325ac1.

♻️ This comment has been updated with latest results.

@wangchao1230 wangchao1230 merged commit e28c922 into main Jun 20, 2024
51 checks passed
@wangchao1230 wangchao1230 deleted the zhrua/fix_async_prompty branch June 20, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants