Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the promptflow-azure an optional dependency; fix artifact logging. #3403

Merged
merged 46 commits into from
Jun 20, 2024

Conversation

nick863
Copy link
Contributor

@nick863 nick863 commented Jun 12, 2024

Description

  • Make promptflow-azure as an optional dependency
  • Fix the mlflow-like artifact logging so that it shows in the UI.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Jun 12, 2024

promptflow-evals test result

  9 files  ±0    9 suites  ±0   2h 3m 5s ⏱️ - 6m 38s
 52 tests ±0   47 ✅ ±0   5 💤 ±0  0 ❌ ±0 
468 runs  ±0  423 ✅ ±0  45 💤 ±0  0 ❌ ±0 

Results for commit 7b64958. ± Comparison against base commit e0a7815.

♻️ This comment has been updated with latest results.

@nick863 nick863 requested a review from singankit June 19, 2024 16:41
@nick863 nick863 requested a review from ninghu June 19, 2024 19:11
@nick863 nick863 requested review from singankit and ninghu June 19, 2024 20:46
@nick863 nick863 changed the title Remove the promptflow-azure dependency Make the promptflow-azure an optional dependency; fix artifact logging. Jun 20, 2024
@singankit singankit merged commit 00c720f into main Jun 20, 2024
37 checks passed
@singankit singankit deleted the nirovins/remove_azure branch June 20, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants