No input mapping fix for dag flows #3377

singankit · 2024-06-05T06:11:10Z

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

The pull request does not introduce [breaking changes].
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.
Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

github-actions · 2024-06-05T06:15:00Z

promptflow SDK CLI Azure E2E Test Result users/singankit/dag_flow_load_flow_bug

4 files 4 suites 1m 31s ⏱️
243 tests 126 ✅ 40 💤 0 ❌ 77 🔥
972 runs 504 ✅ 160 💤 0 ❌ 308 🔥

For more details on these errors, see this check.

Results for commit bd9b411.

github-actions · 2024-06-05T06:17:55Z

promptflow-core test result

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit bd9b411.

github-actions · 2024-06-05T06:18:04Z

SDK CLI Global Config Test Result users/singankit/dag_flow_load_flow_bug

6 tests 6 ✅ 59s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit bd9b411.

github-actions · 2024-06-05T06:21:31Z

Executor Unit Test Result users/singankit/dag_flow_load_flow_bug

797 tests 796 ✅ 3m 45s ⏱️
1 suites 0 💤
1 files 1 ❌

For more details on these failures, see this check.

Results for commit bd9b411.

github-actions · 2024-06-05T06:22:25Z

Executor E2E Test Result users/singankit/dag_flow_load_flow_bug

246 tests 240 ✅ 5m 1s ⏱️
1 suites 6 💤
1 files 0 ❌

Results for commit bd9b411.

github-actions · 2024-06-05T06:32:12Z

SDK CLI Test Result users/singankit/dag_flow_load_flow_bug

4 files 4 suites 1h 4m 44s ⏱️
784 tests 757 ✅ 20 💤 7 ❌
3 136 runs 3 028 ✅ 80 💤 28 ❌

For more details on these failures, see this check.

Results for commit bd9b411.

wangchao1230 · 2024-06-05T08:10:40Z

src/promptflow-core/promptflow/_utils/inputs_mapping_utils.py

@@ -86,6 +86,11 @@ def apply_inputs_mapping(
            ),
            invalid_relations=invalid_relations,
        )
+
+    # if no input mapping is provided, return the original inputs which is data
+    if not result:


add more PR description on what's the case fixed in this PR?

thy09 · 2024-06-05T09:39:50Z

src/promptflow-core/promptflow/_utils/inputs_mapping_utils.py

@@ -86,6 +86,11 @@ def apply_inputs_mapping(
            ),
            invalid_relations=invalid_relations,
        )
+
+    # if no input mapping is provided, return the original inputs which is data


I think it is not a good idea to add such fallback logic in the "apply_inputs_mapping" function, it should know nothing about the special key "data". If we want to do something special for "data", we'd better handle it outside the utils, where the specific scenario uses it.

github-actions · 2024-06-19T21:32:58Z

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

singankit · 2024-06-19T21:35:37Z

This is under discussion

No input mapping fix for dag flows

bd9b411

singankit requested review from a team as code owners June 5, 2024 06:11