Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-list-preview): pass value to onAction callback #31803

Merged
merged 12 commits into from
Jun 26, 2024

Conversation

george-cz
Copy link
Contributor

Previous Behavior

Previously onAction callback did not receive a value prop.

New Behavior

onAction callback receives the value prop as second argument.

Related Issue(s)

@george-cz george-cz requested a review from a team as a code owner June 24, 2024 21:12
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 24, 2024

📊 Bundle size report

✅ No changes found

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature of a callback is not compliant with other components, see the comment.

@george-cz george-cz merged commit df9899f into microsoft:master Jun 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: ListItem onAction should pass value
3 participants