-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for runtime logging not supported with GPTAssistantAgent #2659
Conversation
@pk673 good that you started this. Can you work together with @krishnashed on this PR? I think he can submit a PR to your branch on your repo. |
@Hk669 there is still some work left. I'll request for changes when needed |
yeah sure. Thanks |
@krishnashed Could you please elaborate on the changes that are still pending? |
@pk673 can we connect? What's your discord username? |
@krishnashed can you add me to the discussion? Thanks |
@krishnashed @Hk669 My discord username is priyam_20775 |
@Hk669 Can you please let me know what changes are required? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pk673 I tested your changes, they are good to be merged.
Can you also add me to the discord chat? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krishnashed i think this is only logging the last response of the group chat in chat completion log. is this issue solved?
@pk673 please look into the above issue
issue addressed in #2677 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
@pk673 thanks for the contribution. |
Co-authored-by: HRUSHIKESH DOKALA <[email protected]> Co-authored-by: Eric Zhu <[email protected]>
Please review @IANTHEREAL @cheng-tan @jtrugman @ekzhu
Why are these changes needed?
With this change we aim to support runtime-logging with GPTAssistantAgent
Related issue number
Closes #2498
#2644
Checks