[wip] Shared resolutions in tsserver #55968
Draft
+6,876
−2,092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
sheetalkamat
force-pushed
the
sharedResolutions
branch
2 times, most recently
from
ad81eea
to
a0f7406
Compare
sheetalkamat
force-pushed
the
sharedResolutions
branch
5 times, most recently
from
6fe87d6
to
d947de4
Compare
sheetalkamat
force-pushed
the
sharedResolutions
branch
2 times, most recently
from
bf1aaea
to
73e6924
Compare
sheetalkamat
force-pushed
the
sharedResolutions
branch
from
939f761
to
a797369
Compare
This was referenced Jun 26, 2024
sheetalkamat
force-pushed
the
sharedResolutions
branch
from
a797369
to
093cf96
Compare
First unresolved import gets the typing file into cache and sets it as root, This results in scheduling new typing request with that unresolved import missing The result will come back with typing file that is omitted, so root file will change but file will still be part of program so its not really removed from program
Also cache the inferred type acquition for inferred project
…pings cache This change finally makes all tests pass incremental tests for matching resolutions and program structuture
…pass, invalidate them at usage site
…eed to update last cached unresolved imports just because we have new program
…s in the program This shows cache is holding onto resolutions that are no longer needed by program because either those modules arent present in file or is determined to be ambient resolution
…ns are reused/are resolved to ambient module names
…ay instead of defering external module reoslutions to watch all failed lookup locations
But when do we gc Resolution caches esp for non relative names etc? Also TODO:: handle change in module reosolution options Postpone stopping watching resolutions as they can still be shared from different file
sheetalkamat
force-pushed
the
sharedResolutions
branch
from
093cf96
to
3f2a098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working and creating PR to do testing as i push commits
Rework of #55067