[CMake] Use CMAKE_MSVC_RUNTIME_LIBRARY to apply /MT #6484
+2
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
requested review from
guolinke,
jameslamb,
shiyu1994,
jmoralez and
borchero
as code owners
hcho3
commented
Jun 14, 2024
jameslamb
requested changes
Jun 17, 2024
jameslamb
reviewed
Jun 20, 2024
| string(REPLACE "/MD" "/MT" ${CompilerFlag} "${${CompilerFlag}}") | ||
| endforeach() | ||
| # Use /MT flag to statically link the C runtime | ||
| set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>") |
There was a problem hiding this comment.
@hcho3 could you please look into https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=16422&view=logs&j=1f4df553-f999-5fff-c6fe-71123c872ae2&t=3537c7a9-e1e2-54d5-18f4-f7d9e02b9f6d?
boosting.obj : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MTd_StaticDebug' in test_array_args.obj [D:\a\1\s\build\testlightgbm.vcxproj]
Does this maybe need to be set earlier, before the target is declared, to affect the flags? I'm not really sure.
There was a problem hiding this comment.
Yes, I think this has to be set before targets are created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the built-in flag
CMAKE_MSVC_RUNTIME_LIBRARYin CMake to robustly handle the linking mode for the Windows C runtime (/MDvs/MT). See https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html