Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dataset_loader.cpp #6483

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

eltociear
Copy link
Contributor

intial -> initial

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much for taking the time to contribute!

I found a few more cases of this particular typo:

git grep -i intial

Could you please fix those too?

@borchero
Copy link
Collaborator

@jameslamb we could think about adding typos as a pre-commit hook. It minimizes false positives by using a list of well-known typos rather than defining a dictionary of valid words 😄

@jameslamb
Copy link
Collaborator

@borchero oh very cool, I hadn't seen that before! Let's try it, it looks great. Could you put up a separate PR?

I'll merge this one as-is without waiting to fix the other couple uses of intial, so @eltociear can get their first contribution here and so we don't have to wait on this to add that pre-commit check.

@jameslamb jameslamb self-requested a review June 17, 2024 00:47
@jameslamb jameslamb merged commit d56a7a3 into microsoft:master Jun 17, 2024
41 checks passed
@jameslamb
Copy link
Collaborator

thanks for taking the time to contribute, come back any time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants