[CUDA] Multi-GPU for CUDA Version #6138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiyu1994
requested review from
guolinke,
jameslamb and
jmoralez
as code owners
shiyu1994
changed the title
shiyu1994
changed the title
fix lint errors
|
@guolinke This is almost ready. You may review this when you have time. Thanks. |
|
are there any tests for the multi-GPU training? |
jameslamb
reviewed
Feb 24, 2024
|
|
||
| - ``num_gpu`` :raw-html:`<a id="num_gpu" title="Permalink to this parameter" href="#num_gpu">🔗︎</a>`, default = ``1``, type = int, constraints: ``num_gpu > 0`` |
There was a problem hiding this comment.
I'm ok with changing the main parameter name to num_gpus, but can we please keep num_gpu as a parameter alias? So that existing code using that parameter isn't broken?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to integrate multi-GPU support for CUDA version, with NCCL.