Add and Remove ZeRO 3 Hooks #5658
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jomayeri, please add some unit tests |
tjruwase
reviewed
Jun 18, 2024
|
|
||
|
|
||
| @contextmanager | ||
| def unwrap_model_for_generation(model): |
There was a problem hiding this comment.
It is better to use general naming that describes what the utility does rather than specific usage like generation.
Suggested change
| def unwrap_model_for_generation(model): | |
| def unshard_and_remove_hooks(model): |
tjruwase
reviewed
Jun 18, 2024
| if model.optimizer is not None and hasattr(model.optimizer, "parameter_offload"): | ||
| optimizer_offload = model.optimizer.parameter_offload | ||
| elif model.optimizer is not None: | ||
| optimizer_offload = model.optimizer |
There was a problem hiding this comment.
Can you explain this zero-3 case where we have hooks attached to the optimizer?
tjruwase
reviewed
Jun 18, 2024
| elif model.optimizer is not None: | ||
| optimizer_offload = model.optimizer | ||
|
|
||
| for hook in optimizer_offload.forward_hooks: |
There was a problem hiding this comment.
The hooks are associated with parameters not optimizer, so this naming is a bit confusing. Let's clarify this.
Suggested change
| for hook in optimizer_offload.forward_hooks: | |
| for hook in parameter_offload.forward_hooks: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives the ability to add and remove the forward hooks in ZeRO 3 by using a context manager. These code changes were taken from a Huggingface PR and integrated for direct support in DeepSpeed.
This is useful in the inference case and the speedup can be observed here.