Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3948] Update dotnet samples to target .Net 8 - Skills samples #3983

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #3948
#minor

Important

These changes depend on PR #3982 being merged, so the CI pipeline pass successfully with .NET 8.

Description

This PR updates the Skills samples to target .NET 8

Specific Changes

  • Updated the following samples to target .NET 8
    • 80.skills-simple-bot-to-bot
    • 81.skills-skilldialog
    • 82.skills-sso-cloudadapter
  • README files updated to target .NET 8
  • Fixed an issue with skills-sso-cloudadapter when obtaining the Skill ID from claims.

Testing

These images show the updated bots working as expected.
80.skills-simple-bot-to-bot
imagen
81.skills-skilldialog
imagen
82.skills-sso-cloudadapter
imagen

@sw-joelmut sw-joelmut requested a review from a team as a code owner June 7, 2024 12:36
@tracyboehrer tracyboehrer merged commit 369186d into main Jun 25, 2024
2 of 3 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/net8-skills branch June 25, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants