Initialize options for accounts from settings.json #13194
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v3-migration-docs canceled.
|
✅ Deploy Preview for v3-meteor-api-docs canceled.
|
denihs
requested changes
Jun 14, 2024
| @@ -274,15 +282,15 @@ export class AccountsCommon { | |||
| } | |||
|
|
|||
| // Validate config options keys | |||
| Object.keys(options).forEach(key => { | |||
| for (const key of Object.keys(options)) { | |||
There was a problem hiding this comment.
Why use for of instead of forEach?
There was a problem hiding this comment.
Better performance according to: https://romgrk.com/posts/optimizing-javascript
| // TODO[FIBERS]: I need TLA | ||
| Accounts.init().then() | ||
| Accounts.init().then(); |
There was a problem hiding this comment.
Can you check if TLA works here?
There was a problem hiding this comment.
I will, but that is out of scope of this PR.
There was a problem hiding this comment.
Run Meteor from checkout with await Accounts.init(); and didn't get any error. I can change the code here if you want.
denihs
reviewed
Jun 14, 2024
….com/meteor/meteor into feature/accounts-server-options-init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this earlier that
Meteor.settings.packages.accounts-baseis not properly initialized on server. I think we used to have this and it might have gotten lost, so I've looked through things and made fixes to ensure those settings get picked up properly.