-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meteor 3] Fix how to compare constraints version when publishing a package #13082
Conversation
✅ Deploy Preview for v3-meteor-api-docs canceled.
|
I'm wondering if we could develop tests to aid in this verification process. Could we add a self-test for this build stuff, perhaps even unit testing for this specific handling? |
✅ Deploy Preview for v3-migration-docs canceled.
|
I tested this with the cause for the error from #13111, and this PR incorrectly allows the inconsistent constraints. If you add this to
Meteor should error since having different constraints for a package in #13111 only updates one place that calls |
I took time to analyze everything here, and #13111 gives me the fitting errors to solve the issue. This code is in fact not correct. I'm closing this PR. |
We had reports that people weren't able to deploy packages because they were getting the error:
Debugging further, I could check that here,
d.constraint
anduse.constraint
were never equal if usingapi.versionsFrom
with conditioning versions for a package, like'[email protected]||2.0.0-beta300.7'
.What I'm doing on this PR is to verify if the package constraint version is available in the specified Meteor version determined by
api.versionsFrom
.