Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): manage inventory items for variants #7800

Merged
merged 9 commits into from
Jun 26, 2024
Merged

feat(dashboard): manage inventory items for variants #7800

merged 9 commits into from
Jun 26, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Jun 21, 2024

What

  • manage inventory items from the variant details page
Screen.Recording.2024-06-21.at.15.25.46.mov

CLOSES CORE-2358

@fPolic fPolic requested a review from a team as a code owner June 21, 2024 13:27
@vercel Vercel
Copy link

vercel bot commented Jun 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 7:19am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jun 26, 2024 7:19am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 7:19am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 7:19am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 693f705

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fPolic fPolic requested a review from olivermrbl June 21, 2024 13:27
@olivermrbl
Copy link
Contributor

Missing translation key:
CleanShot 2024-06-24 at 13 11 14

olivermrbl
olivermrbl approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, minor things but otherwise LGTM

packages/admin-next/dashboard/src/i18n/translations/en.json Outdated Show resolved Hide resolved
...items/components/manage-variant-inventory-items-form/manage-variant-inventory-items-form.tsx Outdated Show resolved Hide resolved
@olivermrbl olivermrbl merged commit 8703f45 into develop Jun 26, 2024
20 checks passed
@olivermrbl olivermrbl deleted the feat/manage-variant-inventory-items branch June 26, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fPolic @olivermrbl @srindom