Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto generate table name #3637

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Auto generate table name #3637

wants to merge 8 commits into from

Conversation

Anish9901
Copy link
Member

@Anish9901 Anish9901 commented Jun 21, 2024

Fixes #3636

Replicates the current behaviour our table add REST endpoint and generate table name if one isn't provided.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Anish9901 Anish9901 changed the title add generate a table name if not given Auto generate table name if one isn't provided Jun 21, 2024
@Anish9901 Anish9901 changed the title Auto generate table name if one isn't provided Auto generate table name Jun 21, 2024
@Anish9901 Anish9901 added the pr-status: review A PR awaiting review label Jun 21, 2024
fq_table_name := format('%I.%I', schema_name, tab_name);
ELSE
SELECT COUNT(*) INTO table_count FROM pg_catalog.pg_class WHERE relkind = 'r' AND relnamespace = sch_id;
fq_table_name := format('%I.%I', schema_name, 'Table ' || (table_count + 1));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong, but I think there may be a bug here. Say I begin with zero tables...

  1. I create a table. It gets named Table 1.
  2. I create another table. It gets named Table 2.
  3. I delete the first table.
  4. I create a third table. Within this function table_count will be 1 so fq_table_name will be something like public."Table 2". But public."Table 2" already exists so CREATE TABLE will fail.

Right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct @seancolsen, I've fixed the bug and added a test in 0450fbe, thanks for catching it!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I haven't reviewed thoroughly, but your changes look good from a glance. I'll leave it to Brent to review fully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto generate table_name in add_mathesar_table func
3 participants