fix: Remove IfElse To Keep State Correct #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladyslavsosiuk
force-pushed
the
bugfix/swiftui-indentification
branch
from
345c0cd
to
95ae26b
Compare
|
Thanks for this @vladyslavsosiuk. It's a critical issue imo, let's hope it gets merged sometime soon. |
|
Did you notice that on the video with expected behavior part of the toggle button on the right is cut off? |
Yes, it's just a preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #12
This PR addresses the SwiftUI identification issue. When a view to which the shimmering modifier is applied has its own state and toggles between shimmering active true or false the view would lose its state. Here's a video representing the issue:
Screen.Recording.2023-11-06.at.11.16.07.AM.mov
Here is a video with the expected behavior:
Screen.Recording.2023-11-06.at.11.16.38.AM.mov
why is this an issue described in the following article:
https://www.objc.io/blog/2021/08/24/conditional-view-modifiers/