Usability: Add filter modal for exercises
#8858
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-glombik
commented
Jun 23, 2024
| return exercise | ||
| .categories!.flatMap((category: ExerciseCategory) => this.filterMap.get(category.category!)!) | ||
| .reduce((value1: boolean, value2: boolean) => value1 || value2); | ||
| return exercise.categories!.flatMap((category: ExerciseCategory) => this.filterMap.get(category.name!)!).reduce((value1: boolean, value2: boolean) => value1 || value2); |
There was a problem hiding this comment.
No change in logic, this line is now only wrapped because it is a few chars shorter after renaming
florian-glombik
force-pushed
the
feature/general/add-exercise-filter
branch
from
de29694
to
0ec5246
Compare
…ilter # Conflicts: # src/main/webapp/app/shared/sidebar/sidebar-accordion/sidebar-accordion.component.ts # src/main/webapp/app/shared/sidebar/sidebar.component.ts
florian-glombik
commented
Jun 29, 2024
Comment on lines
-370
to
+373
| exercise.categories = exercise.categories.map((category) => JSON.parse(category as string) as ExerciseCategory); | ||
| exercise.categories = exercise.categories.map((category) => { | ||
| const categoryObj = JSON.parse(category as unknown as string); | ||
| return new ExerciseCategory(categoryObj.color, categoryObj.category); | ||
| }); |
There was a problem hiding this comment.
We need to use a real object if we want to use the equals method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Client
authoritiesto all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
Description
quizwill not be an available filter option; the same applies to the general filter option - if there is only one exercise type in the course the filter option will not be displayed)CustomExerciseCategoryBadgeComponentRangeSlidercomponent as thengBootstrapdoes not seem to offer such a functionality (https://getbootstrap.com/docs/5.0/forms/range/)Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Screenshots