Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Fix wrong Artemis image issue on Bamboo E2E multinode configuration #8852

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

muradium
Copy link
Contributor

@muradium muradium commented Jun 23, 2024

Checklist

General

Client

Motivation and Context

Bamboo build plan of E2E Playwright tests use wrong Artemis image on multi-node configuration. It uses the develop image rather than PR-related one. As a result, tests are run for a wrong branch and builds either fail/succeed incorrectly or never finish.

Description

This PR changes the pull policy of multi-node configuration on its compose file to default, which means to pull the Artemis image from latest only if there is no image found locally. Fixes Issue #8831.

Another change is to pull the corresponding database image during compose command in shell script, used for deploying the services and running E2E tests. It was using a wrong service name.

Steps for Testing

Check both Playwright E2E single-node and multi-node build plans for correctly executing and finishing the tests. Check video recordings of tests from both build plans to ensure they run on the branch this PR belongs to. To watch the recordings, check the artifacts of these builds:

P.S. E2E test recording of Playwright tests are currently turned off and only the builds on URLs above contain recordings for debugging purposes

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Copy link
Contributor

@JohannesWt JohannesWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Work In Progress
Development

Successfully merging this pull request may close these issues.

Bamboo Playwright E2E Tests with Multinode Configuration Running on Wrong Branch
2 participants