Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 style: Tooltip should not be selected & Model selector overlaps with reset button #2500

Merged
merged 13 commits into from
May 21, 2024

Conversation

sxjeru
Copy link
Contributor

@sxjeru sxjeru commented May 14, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

  • 使鼠标透过 Tooltip 提示内容;
  • 避免模型选择框与重置按钮重叠。

此外可以考虑减小或去除边栏宽度与输入框高度限制。

📝 补充信息 | Additional Information

{39E31D6A-9989-435a-B208-900D833D75B3}.png

736c89b78df19ad6c35ce874cef8bebd.png

Copy link

vercel bot commented May 14, 2024

@sxjeru is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @sxjeru

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.34%. Comparing base (086244c) to head (9a252d4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2500   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files         334      334           
  Lines       20164    20164           
  Branches     2380     2380           
=======================================
  Hits        18822    18822           
  Misses       1342     1342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sxjeru sxjeru changed the title 💄 style: Tooltip Should not be selected 💄 style: Tooltip Should not be selected & misc May 15, 2024
@arvinxx
Copy link
Contributor

arvinxx commented May 21, 2024

@sxjeru PR 分开提哈

使鼠标透过 Tooltip 提示内容;
避免模型选择框与重置按钮重叠。

这两个我看了 OK 了,可以先合,其他的每个 issue 单独拆一个 PR,这样干净,并且不会互相耦合

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@sxjeru PR separate Tiha

Use the mouse to prompt content through the Tooltip;
Avoid overlap of model selection box and reset button.

I have checked these two and they are OK. You can combine them first. Each other issue will be split into a separate PR. This will be clean and will not couple with each other.

@sxjeru
Copy link
Contributor Author

sxjeru commented May 21, 2024

PR 分开提哈

知道了,以后会注意。
大概是代码改动太少,就没有开新 pr 。

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


PR separate Tiha

Got it, I'll pay attention to it in the future.
Probably because there were too few code changes, no new PR was opened.

@arvinxx
Copy link
Contributor

arvinxx commented May 21, 2024

大概是代码改动太少,就没有开新 pr

是否值得构成一个 PR 和代码改动量无关哈。重点是一个 PR 能清楚地说明一件事,尽量保持干净。这样哪怕出问题,也能精准回滚对应的那个。

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Probably because there were too few code changes, no new PR was opened.

Whether it's worth forming a PR has nothing to do with the amount of code changes. The point is that a PR clearly states one thing, try to keep it as clean as possible. In this way, even if something goes wrong, the corresponding one can be accurately rolled back.

@sxjeru sxjeru changed the title 💄 style: Tooltip Should not be selected & misc 💄 style: Tooltip Should not be selected & Model selector overlaps with reset button May 21, 2024
@arvinxx arvinxx changed the title 💄 style: Tooltip Should not be selected & Model selector overlaps with reset button 💄 style: Tooltip should not be selected & Model selector overlaps with reset button May 21, 2024
Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 3:09pm

@arvinxx arvinxx merged commit 0c62fb7 into lobehub:main May 21, 2024
6 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @sxjeru ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

@sxjeru sxjeru deleted the fork4 branch May 21, 2024 15:52
github-actions bot pushed a commit that referenced this pull request May 21, 2024
### [Version 0.160.8](v0.160.7...v0.160.8)
<sup>Released on **2024-05-21**</sup>

#### 💄 Styles

- **misc**: `Tooltip` should not be selected & Model selector overlaps with reset button.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: `Tooltip` should not be selected & Model selector overlaps with reset button, closes [#2500](#2500) [#2511](#2511) [#2581](#2581) ([0c62fb7](0c62fb7))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 0.160.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request May 21, 2024
## [Version&nbsp;1.41.0](v1.40.4...v1.41.0)
<sup>Released on **2024-05-21**</sup>

#### ✨ Features

- **misc**: Add system agent to select another model provider for translation.

#### 💄 Styles

- **misc**: `Tooltip` should not be selected & Model selector overlaps with reset button.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **misc**: Add system agent to select another model provider for translation, closes [lobehub#1902](https://github.com/bentwnghk/lobe-chat/issues/1902) ([3945387](3945387))

#### Styles

* **misc**: `Tooltip` should not be selected & Model selector overlaps with reset button, closes [lobehub#2500](https://github.com/bentwnghk/lobe-chat/issues/2500) [lobehub#2511](https://github.com/bentwnghk/lobe-chat/issues/2511) [lobehub#2581](https://github.com/bentwnghk/lobe-chat/issues/2581) ([0c62fb7](0c62fb7))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants