Enrich ConnectionPoolListener interface to listen more connection events #5580

festinalente91 · 2024-04-08T08:01:07Z

Motivation:

ConnectionPoolListener provides a limited way to listen to connection events. (open, close)
We could provide a more sophisticated event interface like the one below.

Connection pending
Connection failed
Connection active
Connection idle

                                                                                           
                                    +------------------+                                   
        +--------------+            | +--------------+ |            +--------------+       
        |              |            | |              | |            |              |       
        |    Pending   |----------->| |    Opened    | |----------> |    Closed    |       
        |              |            | |              | |            |              |       
        +--------------+            | +--------------+ |            +--------------+       
                |                   |                  |                                   
                |                   |      Active      |                                   
                |                   |         ^        |                                   
                |                   |         |        |                                   
                |                   |         |        |                                   
                v                   |         |        |                                   
        +--------------+            |         |        |                                   
        |              |            |         v        |                                   
        |    Failed    |            |       Idle       |                                   
        |              |            |                  |                                   
        +--------------+            +------------------+

Furthermore, as @ikhoon mentioned here
we can also expand this connection event interface to be used on the server side.

Modifications:

(Deprecated) com.linecorp.armeria.client.ConnectionPoolListener class is deprecated.
- Use com.linecorp.armeria.client.ClientConnectionEventListener instead.

Result:

Now you can handle more detailed connection pool events and metrics.
Closes Enrich ConnectionPoolListener interface to listen to more connection events #4649 .

CLAassistant · 2024-04-08T08:01:13Z

All committers have signed the CLA.

github-actions · 2024-04-08T08:46:44Z

🔍 Build Scan® (commit: `b8873e1`)

Job name	Status	Build Scan®
build-windows-latest-jdk-21	❌ (failure)	https://ge.armeria.dev/s/7pi6yqq4yhf4k
build-self-hosted-unsafe-jdk-8	❌ (failure)	https://ge.armeria.dev/s/obhwbn4gjo2jg
build-self-hosted-unsafe-jdk-21-snapshot-blockhound	❌ (failure)	https://ge.armeria.dev/s/onu66ax6vunlu
build-self-hosted-unsafe-jdk-17-min-java-17-coverage	❌ (failure)	https://ge.armeria.dev/s/w7wcs2zospdx4
build-self-hosted-unsafe-jdk-17-min-java-11	❌ (failure)	https://ge.armeria.dev/s/glnitgb2ucrdg
build-self-hosted-unsafe-jdk-17-leak	❌ (failure)	https://ge.armeria.dev/s/hu6qvyuwcmhz4
build-self-hosted-unsafe-jdk-11	❌ (failure)	https://ge.armeria.dev/s/eqqghijlzn2sa
build-macos-12-jdk-21	❌ (failure)	https://ge.armeria.dev/s/czd26l5txfsb6

ikhoon · 2024-04-17T09:12:23Z

core/src/main/java/com/linecorp/armeria/internal/common/AbstractKeepAliveHandler.java

@@ -181,6 +189,26 @@ public final void onReadOrWrite() {
            lastConnectionIdleTime = System.nanoTime();
        }

+        if (!isServer && !isActive) {


It should be useful if we also support ConnectionPoolListener for servers. Although we are focusing on the client-side implementation, the public API design should take extensibility into consideration.

I propose to add a new ConnectionPoolListener to c.l.a.common package. The new methods will be added to the new ConnectionPoolListener which extends the old ConnectionPoolListener for compatibility. For example:

armeria/core/src/main/java/com/linecorp/armeria/common/encoding/StreamDecoder.java

Line 27 in 1d268aa

public interface StreamDecoder extends com.linecorp.armeria.client.encoding.StreamDecoder {

Related issue: #3722

core/src/main/java/com/linecorp/armeria/internal/common/AbstractKeepAliveHandler.java

codecov · 2024-04-21T11:13:41Z

Codecov Report

Attention: Patch coverage is 78.20513% with 17 lines in your changes missing coverage. Please review.

Project coverage is 74.03%. Comparing base (e08527d) to head (4be97ef).
Report is 6 commits behind head on main.

❗ Current head 4be97ef differs from pull request most recent head b8873e1

Please upload reports for the commit b8873e1 to get more accurate results.

Files	Patch %	Lines
...eria/internal/common/AbstractKeepAliveHandler.java	66.66%	8 Missing and 2 partials ⚠️
.../armeria/client/ConnectionPoolListenerWrapper.java	0.00%	4 Missing ⚠️
...a/com/linecorp/armeria/client/HttpChannelPool.java	50.00%	1 Missing ⚠️
...inecorp/armeria/common/ConnectionPoolListener.java	0.00%	1 Missing ⚠️
...linecorp/armeria/common/ConnectionPoolMetrics.java	96.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #5580      +/-   ##
============================================
- Coverage     74.75%   74.03%   -0.73%     
+ Complexity    21409    21197     -212     
============================================
  Files          1877     1844      -33     
  Lines         79126    78438     -688     
  Branches      10201    10010     -191     
============================================
- Hits          59152    58069    -1083     
- Misses        15179    15668     +489     
+ Partials       4795     4701      -94

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

core/src/main/java/com/linecorp/armeria/client/ConnectionPoolListener.java

trustin

This is really good. Thanks for your high quality contribution, @festinalente91!

core/src/main/java/com/linecorp/armeria/client/ConnectionPoolListener.java

core/src/main/java/com/linecorp/armeria/common/ConnectionPoolListenerAdapter.java

core/src/main/java/com/linecorp/armeria/client/ConnectionPoolListener.java

core/src/main/java/com/linecorp/armeria/common/ConnectionPoolMetrics.java

core/src/main/java/com/linecorp/armeria/common/MetricCollectingConnectionPoolListener.java

core/src/main/java/com/linecorp/armeria/client/ConnectionPoolListener.java

core/src/main/java/com/linecorp/armeria/client/HttpChannelPool.java

ikhoon · 2024-05-08T04:39:41Z

core/src/main/java/com/linecorp/armeria/common/ConnectionPoolListener.java

+/**
+ * Listens to the client connection pool events.
+ */
+public interface ConnectionPoolListener extends com.linecorp.armeria.client.ConnectionPoolListener {


On second thought, ConnectionEventListener would be a better name for the new API than ConnectionPoolListener. Because:

If we use the same name, setter methods can be easily overloaded but it is difficult to name the new API while deprecating the old one.

pool is not a good word for the server side. Servers accept incoming connections but do not manage pooled connections for reuse. Therefore, a more general term, event would make more sense.

Suggested change

public interface ConnectionPoolListener extends com.linecorp.armeria.client.ConnectionPoolListener {

public interface ConnectionEventListener {

Should we deprecate ClientFactoryBuilder.connectionPoolListener() and related methods in favor of ClientFactoryBuilder.connectionEventListener()?
For backward compatibility, we need to convert ConnectionPoolListener to ConnectionEventListener internally.

I like the name. 😊

@ikhoon

Should we deprecate ClientFactoryBuilder.connectionPoolListener() and related methods in favor of ClientFactoryBuilder.connectionEventListener()?

Yes, I think so.

For backward compatibility, we need to convert ConnectionPoolListener to ConnectionEventListener internally.

Okay. I'll convert it.👍

I converted the deprecated ConnectionPoolListener into ClientConnectionEventListener in the ClientFactoryBuilder. if there's already CONNECTION_EVENT_LISTENER, then it just ignores the ConnectionPoolListener.

// ClientConnectionEventListener.class static final ClientConnectionEventListenerAdapter NOOP = new ClientConnectionEventListenerAdapter(); /** * Convert the {@link ConnectionPoolListener} into a {@link ClientConnectionEventListener}. */ static ClientConnectionEventListener of(ConnectionPoolListener connectionPoolListener) { return new ClientConnectionEventListenerAdapter() { @Override public void connectionOpened(@Nullable SessionProtocol desiredProtocol, SessionProtocol protocol, InetSocketAddress remoteAddress, InetSocketAddress localAddress, AttributeMap attrs) throws Exception { connectionPoolListener.connectionOpen(protocol, remoteAddress, localAddress, attrs); } @Override public void connectionClosed(SessionProtocol protocol, InetSocketAddress remoteAddress, InetSocketAddress localAddress, boolean isIdle, AttributeMap attrs) throws Exception { connectionPoolListener.connectionClosed(protocol, remoteAddress, localAddress, attrs); } }; }

// ClientFactoryBuilder.class private ClientFactoryOptions buildOptions() { ... if (options.containsKey(ClientFactoryOptions.CONNECTION_POOL_LISTENER) && !options.containsKey(ClientFactoryOptions.CONNECTION_EVENT_LISTENER)) { final ConnectionPoolListener connectionPoolListener = (ConnectionPoolListener) options.get(ClientFactoryOptions.CONNECTION_POOL_LISTENER).value(); options.put(ClientFactoryOptions.CONNECTION_EVENT_LISTENER, ClientFactoryOptions.CONNECTION_EVENT_LISTENER .newValue(ClientConnectionEventListenerAdapter.of(connectionPoolListener))); }

minwoox

Basically, looks good. 👍

core/src/main/java/com/linecorp/armeria/client/ClientConnectionEventListener.java

core/src/main/java/com/linecorp/armeria/client/ClientFactoryOptions.java

core/src/main/java/com/linecorp/armeria/client/Http1ClientKeepAliveHandler.java

core/src/main/java/com/linecorp/armeria/client/ClientFactoryOptions.java

core/src/main/java/com/linecorp/armeria/client/HttpClientFactory.java

minwoox · 2024-05-14T02:15:32Z

core/src/main/java/com/linecorp/armeria/internal/common/AbstractKeepAliveHandler.java

+        final ConnectionEventKey connectionEventKey = connectionEventKey(channel);
+
+        try {
+            connectionEventListener.connectionOpened(connectionEventKey, channel);


If NoopKeepAliveHandler is used, this event isn't called anymore.

armeria/core/src/main/java/com/linecorp/armeria/client/Http1ResponseDecoder.java

Line 98 in 89e0257

keepAliveHandler = new NoopKeepAliveHandler();

Is there any reason that you've moved this logic from HttpChannelPool?

I tried to move open and close event trigger logic into the AbstractKeepAliveHandler to reuse this on the server side. However, as you said, I had to make extra changes to do that. Any feedback for this? @minwoox @ikhoon

Added connection opened and closed event trigger logic into the NoopKeepAliveHandler

To share the open and close event trigger logic on server side.

Handled HTTP Upgrade cases with context-checking(HttpProtocolUpgradeHandler)

When the protocol is upgraded, AbstractKeepAliveHandler is called twice.

So, I had to ignore the first one which was related to the protocol upgrade process.

(Still struggling to handle HTTP2 Max connection setting test case.

void exceededMaxStreamsPropagatesFailureCorrectly() throws Exception {)

I tried to move open and close event trigger logic into the AbstractKeepAliveHandler to reuse this on the server side

Since the connection mechanisms differ between the server-side and client-side, I don't think we have to put the logic into the same class.
Instead, we could consider incorporating the logic for the server-side into ConnectionLimitingHandler, which is already used for managing connections. You can find the ConnectionLimitingHandler implementation here: Link

core/src/main/java/com/linecorp/armeria/common/ConnectionEventKey.java

ikhoon

Sorry for the late review. I'll take a review in detail tomorrow.

ikhoon · 2024-05-15T05:07:41Z

core/src/main/java/com/linecorp/armeria/common/ConnectionEventKey.java

+/**
+ * A key to identify a connection event.
+ */
+public final class ConnectionEventKey {


Move to the internal package? I guess there is no API in which this class is exposed.

Alternatively, we could also move to the client package and make it package private.

@jrhee17 -nim
Since this ConnectionEventKey class might be used in the server package, how about putting this under the internal.common package?

core/src/main/java/com/linecorp/armeria/common/ConnectionEventKey.java

ikhoon · 2024-06-17T13:54:30Z

core/src/main/java/com/linecorp/armeria/internal/common/AbstractKeepAliveHandler.java

+                    final ConnectionEventKey connectionEventKey = connectionEventKey(ctx.channel());
+
+                    try {
+                        connectionEventListener.connectionIdle(protocol,


I'd like to gather idle and keep-alive related logic into KeepAliveHandler. It is doable to track idle connections in AbstractHttpResponseDecoder but the logic could be fragmented.

We already call KeepAliveHandler when a new request is made.

armeria/core/src/main/java/com/linecorp/armeria/client/AbstractHttpResponseDecoder.java

Line 67 in 2219de1

keepAliveHandler().increaseNumRequests();

How about adding keepAliveHandler().decreaseNumRequests() and just calling it in AbstractHttpResponseDecoder.removeResponse() instead?

…t-interface

jrhee17

Looks good overall, left some minor comments 👍

core/src/main/java/com/linecorp/armeria/client/ClientFactoryOptions.java

jrhee17 · 2024-06-18T02:57:41Z

core/src/main/java/com/linecorp/armeria/client/ClientFactoryBuilder.java

    public ClientFactoryBuilder connectionPoolListener(
            ConnectionPoolListener connectionPoolListener) {
        option(ClientFactoryOptions.CONNECTION_POOL_LISTENER,
               requireNonNull(connectionPoolListener, "connectionPoolListener"));
        return this;
    }

+    /**
+     * Sets the listener which is notified on a connection event.


Can you also update the javadocs to let users know that connectionEventListener won't have an effect if connectionPoolListener is set?

Okay! I would leave the comment that connectionPoolListener won't have an effect if connectionEventListener is set.

I slightly prefer raising an IllegalStateException when both ConnectionPoolListener and ClientConnectionEventListener are set.
We may store a specified ClientConnectionEventListener in a member field and set to options in buildOptions().

public ClientFactoryBuilder connectionPoolListener( ConnectionPoolListener connectionPoolListener) { checkState(connectionEventListener == null, "connectionPoolListener() and connectionEventListener() are mutually exclusive") this.connectionPoolListener = connectionPoolListener; } ... private ClientFactoryOptions buildOptions() { if (connectionPoolListener != null) { // Convert connectionPoolListener to connectionEventListener. } }

core/src/main/java/com/linecorp/armeria/client/ClientConnectionEventListenerAdapter.java

core/src/main/java/com/linecorp/armeria/common/ConnectionEventKey.java

jrhee17 · 2024-06-18T03:53:23Z

core/src/main/java/com/linecorp/armeria/common/ConnectionEventKey.java

+/**
+ * A key to identify a connection event.
+ */
+public final class ConnectionEventKey {


Alternatively, we could also move to the client package and make it package private.

jrhee17 · 2024-06-18T03:54:34Z

core/src/main/java/com/linecorp/armeria/common/ConnectionEventKey.java

+    /**
+     * Returns the desired protocol of the connection. This field is only used for client-side connection.
+     */
+    @Nullable


nit; This doesn't have to be nullable if the ctor requires a desiredProtocol. We can also clean up related code.

Suggested change

@Nullable

I designed the ConnectionEventKey class (and ConnectionEventListener interface) for both the server and the client. Since the desired protocol only exists on the client side, this field has to be nullable for the server side.
Or perhaps we could extend this class to be more client-specific, but I'm getting worried that would make the code unnecessarily hierarchical and hard to read.

…laddr is null

…t-interface

When the sessionPromise fails, sessionPromise.getNow() returns a FailedFuture, which returns the channel as null. To keep the connectionEventState, I added connectionEventStates to the HttpChannelPool.

…t-interface

jrhee17

Left some more comments 👍

jrhee17 · 2024-06-26T13:59:53Z

core/src/main/java/com/linecorp/armeria/client/HttpChannelPool.java

+                    // When the transport type(-Dcom.linecorp.armeria.transportType) is NIO,
+                    // sometimes local address is not available yet.


I believe this is because the channel isn't bound yet at this point. Is there a reason we can't just remove L434-L445?

jrhee17 · 2024-06-26T14:01:30Z

core/src/main/java/com/linecorp/armeria/client/HttpChannelPool.java

@@ -110,6 +112,7 @@ final class HttpChannelPool implements AsyncCloseable {
                                          SessionProtocol.H2, SessionProtocol.H2C));
        pendingAcquisitions = newEnumMap(httpAndHttpsValues());
        allChannels = new IdentityHashMap<>();
+        connectionEventStates = new IdentityHashMap<>();


Question) What is the reason we need this map?

When the sessionPromise failed, I could not get the channel because the future.getNow() returns null.
Also, I couldn't pass the ConnectionEventState to the notifyConnectionFailed method, because the ConnectionEventState is created in the callback.

jrhee17 · 2024-06-26T14:04:59Z

core/src/main/java/com/linecorp/armeria/internal/common/ConnectionEventState.java

+    /**
+     * Creates a new instance.
+     */
+    public ConnectionEventState(InetSocketAddress remoteAddress,


I feel like maintaining the state is doing us more harm than good at this point. What do you think of just removing ConnectionEventState and using ChannelUtil#localAddress, ChannelUtil#remoteAddress, HttpChannelPool#getProtocolIfHealthy when notifying events instead?

jrhee17 · 2024-06-26T14:06:20Z

core/src/main/java/com/linecorp/armeria/internal/common/NoopKeepAliveHandler.java

Note that we'll also have to do bookkeeping on NoopKeepAliveHandler if we're committing to maintaining state in KeepAliveHandler like @ikhoon suggested.

jrhee17 · 2024-06-26T14:07:06Z

core/src/main/java/com/linecorp/armeria/internal/common/NoopKeepAliveHandler.java

@@ -64,4 +64,10 @@ public boolean needsDisconnection() {

    @Override
    public void increaseNumRequests() {}
+
+    @Override
+    public void tryNotifyConnectionActive() {}


What do you think of just adding a decreaseNumRequests at the location suggested by @ikhoon at this comment?
#5580 (comment)

ikhoon · 2024-06-26T12:49:56Z

core/src/main/java/com/linecorp/armeria/client/ClientConnectionEventListenerAdapter.java

+    /**
+     * Convert the {@link ConnectionPoolListener} into a {@link ClientConnectionEventListener}.
+     */
+    static ClientConnectionEventListener of(ConnectionPoolListener connectionPoolListener) {


Should we place this method in ClientConnectionEventListener?

It would be better to move this to the ClientFactoryBuilder. 👍

ikhoon · 2024-06-26T13:03:40Z

core/src/main/java/com/linecorp/armeria/client/ClientFactoryBuilder.java

    public ClientFactoryBuilder connectionPoolListener(
            ConnectionPoolListener connectionPoolListener) {
        option(ClientFactoryOptions.CONNECTION_POOL_LISTENER,
               requireNonNull(connectionPoolListener, "connectionPoolListener"));
        return this;
    }

+    /**
+     * Sets the listener which is notified on a connection event.


I slightly prefer raising an IllegalStateException when both ConnectionPoolListener and ClientConnectionEventListener are set.
We may store a specified ClientConnectionEventListener in a member field and set to options in buildOptions().

public ClientFactoryBuilder connectionPoolListener( ConnectionPoolListener connectionPoolListener) { checkState(connectionEventListener == null, "connectionPoolListener() and connectionEventListener() are mutually exclusive") this.connectionPoolListener = connectionPoolListener; } ... private ClientFactoryOptions buildOptions() { if (connectionPoolListener != null) { // Convert connectionPoolListener to connectionEventListener. } }

ikhoon · 2024-06-26T13:23:37Z

core/src/main/java/com/linecorp/armeria/client/HttpChannelPool.java

@@ -92,16 +93,17 @@ final class HttpChannelPool implements AsyncCloseable {
    // Fields for pooling connections:
    private final Map<PoolKey, Deque<PooledChannel>>[] pool;
    private final Map<PoolKey, ChannelAcquisitionFuture>[] pendingAcquisitions;
+    private final Map<Future<Channel>, ConnectionEventState> connectionEventStates;


Should we pass ConnectionEventState as an argument instead? I'm unsure Future<Channel> is a good key and we may implement without this.

I agree that the Future is not a good key and passing it as an argument is much cleaner.
However, since the ConnectionEventState is created inside the sessionPromise callback, there is no way to pass it to the notifyConnect method.

ikhoon · 2024-06-26T13:24:26Z

core/src/main/java/com/linecorp/armeria/client/HttpChannelPool.java

@@ -407,14 +410,39 @@ void connect(SocketAddress remoteAddress, SessionProtocol desiredProtocol,
                // to HttpSessionHandler.
                connectionPromise.addListener((ChannelFuture connectFuture) -> {
                    if (connectFuture.isSuccess()) {
+                        // When the transport type(-Dcom.linecorp.armeria.transportType) is NIO,
+                        // sometimes local address is not available yet.


ikhoon · 2024-06-26T13:26:15Z

core/src/main/java/com/linecorp/armeria/client/HttpChannelPool.java

@@ -407,14 +410,39 @@ void connect(SocketAddress remoteAddress, SessionProtocol desiredProtocol,
                // to HttpSessionHandler.
                connectionPromise.addListener((ChannelFuture connectFuture) -> {
                    if (connectFuture.isSuccess()) {
+                        // When the transport type(-Dcom.linecorp.armeria.transportType) is NIO,
+                        // sometimes local address is not available yet.
+                        if (ChannelUtil.connectionEventState(channel) == null) {


As a connection is just created, is this condition always true?

ikhoon · 2024-06-26T13:27:07Z

core/src/main/java/com/linecorp/armeria/client/HttpChannelPool.java

+
+                final InetSocketAddress remoteInetAddress = poolKey.endpoint.toSocketAddress(-1);
+                final InetSocketAddress localAddress = ChannelUtil.localAddress(channel);
+
+                if (localAddress == null) {
+                    // When the transport type(-Dcom.linecorp.armeria.transportType) is NIO,
+                    // sometimes local address is not available yet.
+                    return;
+                }
+
+                notifyConnectionPending(desiredProtocol, remoteInetAddress, localAddress,
+                                        channel, sessionPromise);


Let's remove and keep the approach above.

ikhoon · 2024-06-27T11:54:22Z

This became a big PR with more than 2000 lines. As a first-time contributor, you are not familiar with Armeria's code internals and conventions. It is also not easy for us to review over 2000 lines.

Let me add a clean-up commit and build together. 😉

…tion-pool-listener-event-interface

github-actions bot requested review from ikhoon, jrhee17, minwoox and trustin April 8, 2024 08:01

festinalente91 force-pushed the feature/enrich-connection-pool-listener-event-interface branch from b52f5a3 to 2851ee6 Compare April 8, 2024 08:41

ikhoon added new feature sprint Issues for OSS Sprint participants labels Apr 8, 2024

festinalente91 force-pushed the feature/enrich-connection-pool-listener-event-interface branch 2 times, most recently from 9f7edb8 to 1da16f2 Compare April 17, 2024 01:12

ikhoon reviewed Apr 17, 2024

View reviewed changes

core/src/main/java/com/linecorp/armeria/internal/common/AbstractKeepAliveHandler.java Outdated Show resolved Hide resolved

festinalente91 force-pushed the feature/enrich-connection-pool-listener-event-interface branch from 416f42b to 4be97ef Compare April 21, 2024 10:38

festinalente91 force-pushed the feature/enrich-connection-pool-listener-event-interface branch from 918d3ac to 6250594 Compare April 28, 2024 03:42

trustin reviewed May 2, 2024

View reviewed changes

core/src/main/java/com/linecorp/armeria/client/ConnectionPoolListener.java Outdated Show resolved Hide resolved

festinalente91 force-pushed the feature/enrich-connection-pool-listener-event-interface branch 5 times, most recently from edcff6b to 5a4530a Compare May 7, 2024 01:52

festinalente91 requested a review from ikhoon May 7, 2024 04:46

festinalente91 marked this pull request as ready for review May 7, 2024 04:50

trustin approved these changes May 7, 2024

View reviewed changes

ikhoon reviewed May 8, 2024

View reviewed changes

festinalente91 force-pushed the feature/enrich-connection-pool-listener-event-interface branch from 5a4530a to 89e0257 Compare May 12, 2024 03:34

minwoox reviewed May 14, 2024

View reviewed changes

festinalente91 force-pushed the feature/enrich-connection-pool-listener-event-interface branch 2 times, most recently from e99fa5d to 6e4e7e5 Compare May 14, 2024 13:25

Move connectionClosed to be called at the HttpChannelPool

7564086

festinalente91 force-pushed the feature/enrich-connection-pool-listener-event-interface branch from aa47532 to 7564086 Compare June 2, 2024 15:29

minwoox added this to the 1.30.0 milestone Jun 3, 2024

Fix to handle session protocol negotiation failure

c2d259a

ikhoon reviewed Jun 17, 2024

View reviewed changes

Merge branch 'main' into feature/enrich-connection-pool-listener-even…

0aa340d

…t-interface

jrhee17 reviewed Jun 18, 2024

View reviewed changes

festinalente91 and others added 11 commits June 18, 2024 16:17

Clean up code

e0cda77

Fix lint

3730964

Delegate keepalive-related connection event handling to KeepAliveHandler

bfdc0c0

Skip notifying connection pending, when the transport is NIO and loca…

1c57ad1

…laddr is null

Ignore HTTP protocol upgrade case

c09c901

Fix to call tryNotifyConnectionIdle when the unfinishedResponses is zero

3ba97d0

Fix ServerMetricsTest to await first

bdbab3d

Add MetricCollectingClientConnectionEventListener

73fd998

Merge branch 'main' into feature/enrich-connection-pool-listener-even…

05ee717

…t-interface

Enhance test

f624867

Handle connection failed case

f7231d4

When the sessionPromise fails, sessionPromise.getNow() returns a FailedFuture, which returns the channel as null. To keep the connectionEventState, I added connectionEventStates to the HttpChannelPool.

festinalente91 requested review from ikhoon, jrhee17 and minwoox June 25, 2024 11:21

festinalente91 and others added 4 commits June 25, 2024 21:08

Clean up code with KeepAliveState enum

a6b59e2

Clean up comment in the test

795f394

Fix to hide KeepAliveState enum

7a90c51

Merge branch 'main' into feature/enrich-connection-pool-listener-even…

feeb0f4

…t-interface

jrhee17 reviewed Jun 26, 2024

View reviewed changes

ikhoon reviewed Jun 26, 2024

View reviewed changes

ikhoon added 2 commits June 28, 2024 15:39

Merge branch 'main' into pr-5580-festinalente91-feature/enrich-connec…

f10039d

…tion-pool-listener-event-interface

Introduce DelegatingConnectionEventListener

b8873e1

	public interface ConnectionPoolListener extends com.linecorp.armeria.client.ConnectionPoolListener {
	public interface ConnectionEventListener {

		// When the transport type(-Dcom.linecorp.armeria.transportType) is NIO,
		// sometimes local address is not available yet.

Enrich ConnectionPoolListener interface to listen more connection events #5580

Are you sure you want to change the base?

Enrich ConnectionPoolListener interface to listen more connection events #5580

Conversation

festinalente91 commented Apr 8, 2024 • edited Loading

CLAassistant commented Apr 8, 2024 • edited Loading

github-actions bot commented Apr 8, 2024 • edited Loading

🔍 Build Scan® (commit: b8873e1)

Choose a reason for hiding this comment

codecov bot commented Apr 21, 2024 • edited Loading

Codecov Report

trustin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

festinalente91 May 14, 2024 • edited Loading

Choose a reason for hiding this comment

minwoox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

festinalente91 May 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ikhoon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ikhoon Jun 17, 2024 • edited Loading

Choose a reason for hiding this comment

jrhee17 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jrhee17 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ikhoon commented Jun 27, 2024

festinalente91 commented Apr 8, 2024 •

edited

Loading

CLAassistant commented Apr 8, 2024 •

edited

Loading

github-actions bot commented Apr 8, 2024 •

edited

Loading

🔍 Build Scan® (commit: `b8873e1`)

codecov bot commented Apr 21, 2024 •

edited

Loading

festinalente91 May 14, 2024 •

edited

Loading

festinalente91 May 14, 2024 •

edited

Loading

ikhoon Jun 17, 2024 •

edited

Loading