Add builder for Backoff #5488
Add builder for Backoff #5488
Conversation
| return new Builder(); | ||
| } | ||
|
|
||
| public static class Builder { |
There was a problem hiding this comment.
Code style) We prefer top-level builder classes instead of nested classes.
Could you move this class to ExpontionalBackoffBuilder?
| public static Builder builder() { | ||
| return new Builder(); | ||
| } |
There was a problem hiding this comment.
Instead of adding a builder method to each implementation, should we add a builder method Backoff interface?
interface Backoff {
static ExpontionalBackoffBuilder builderForExpontional() {
...
}
}Note that ExponentialBackoff is a package-private class that users can't access.
| return new ExponentialBackoff(initialDelayMillis, maxDelayMillis, multiplier); | ||
| } | ||
|
|
||
| public Builder initialDelayMillis(long initialDelayMillis) { |
There was a problem hiding this comment.
Should we make jitter values configured with this builder?
| private long maxDelayMillis; | ||
|
|
||
| FibonacciBackoff build() { | ||
| return new FibonacciBackoff(initialDelayMillis, maxDelayMillis); |
There was a problem hiding this comment.
Should we migrate all factory methods where constructors are used into builder methods? e.g.
kth496
force-pushed
the
add-builder-for-backoff
branch
from
35255b9
to
6ed81ab
Compare
|
@ikhoon Thank you for your review. I will fix it within a week. |
|
@kth496 Looking forward to seeing more commits in this PR 💟 |
|
@kth496 Any updates? |
Motivation:
Backoff#5483Modifications:
Builderclass for various backoff implementations.Result:
Backoff#5483