Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce MANIFEST.in #1565

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Reintroduce MANIFEST.in #1565

merged 1 commit into from
Jun 26, 2024

Conversation

philippmwirth
Copy link
Contributor

Reintroduce MANIFEST.in

With [tool.setuptools.exclude-package-data] the excluded directories are still packaged. Reintroducing MANIFEST.in fixes the problem. The test release on pypitest looks good: https://test.pypi.org/project/lightly/

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (58a3c0d) to head (b910bc4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1565   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files         144      144           
  Lines        6119     6119           
=======================================
  Hits         5006     5006           
  Misses       1113     1113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ikondrat ikondrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@philippmwirth philippmwirth merged commit a6a3aa7 into master Jun 26, 2024
10 checks passed
@philippmwirth philippmwirth deleted the philipp-reintroduce-manifest branch June 26, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants