Fix tweet images not appearing #717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericshively is attempting to deploy a commit to the leerob-site Team on Vercel. A member of the Team first needs to authorize it. |
|
This seems to be working for me. Are you seeing something differently? |
Oh, only checked Firefox. It seems to be working on Chrome and Safari, desktop and mobile, but I turned off my extensions on Firefox and my screenshot seems to reflect Firefox desktop and mobile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently your website blog in prod. has the embedded tweets missing their images.
Exhibit A: https://leerob.io/blog/using-nextjs
Following the standard react-tweet library documentation:
https://react-tweet.vercel.app/next#adding-nextimage
I've added the minimal missing lines to fix this.
Cloned the repo, added this commit, verified my local instance was pulling the images now, albeit with a little awkward shift via <Image fill />