Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert boolean for migrate error message. (#3275) #3276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nk9
Copy link

@nk9 nk9 commented Jun 9, 2024

fixes #3275

@nk9
Copy link
Author

nk9 commented Jun 9, 2024

Question: instead of "see docs," can/should we link to the exact section that's relevant? In this case https://docs.rs/sqlx/latest/sqlx/attr.test.html#automatic-test-database-management-requires-migrate-feature

@nk9
Copy link
Author

nk9 commented Jun 9, 2024

I see that other places in the code use e.g. cfg!(not(feature = "chrono")). I'm not sure if there's a difference between these two styles, but I am happy to align this if desired.

@abonander
Copy link
Collaborator

abonander commented Jun 28, 2024

Question: instead of "see docs," can/should we link to the exact section that's relevant? In this case https://docs.rs/sqlx/latest/sqlx/attr.test.html#automatic-test-database-management-requires-migrate-feature

The biggest issue is the doc header getting changed and it not getting updated here; at most I'd link to the #[sqlx::test] attribute itself. Either way, the user should probably read the whole page to understand what they're doing anyway.

I see that other places in the code use e.g. cfg!(not(feature = "chrono")). I'm not sure if there's a difference between these two styles, but I am happy to align this if desired.

I don't care that much, but that does seem more readable.

@abonander
Copy link
Collaborator

@nk9 if you rebase it should fix the CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlx::test error message incorrectly implies migrate feature is disabled
2 participants