Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Nightly and release jobs should not be run on fork repositories #1302 #1303

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

Wadimz
Copy link
Contributor

@Wadimz Wadimz commented Jun 16, 2024

This change addresses issue described in bug: [BUG] Nightly and release jobs should not be run on fork repositories #1302
Change was verified on fork using fork repository path.

Issue

#1302

Change

Change adds github job condition to be run only on the main project's repository.

General checklist

  • There are no breaking changes
  • I have added unit and integration tests for my change
  • I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
  • I have manually run all the unit and integration tests in the core and main modules, and they are all green

Checklist for adding new model integration

  • I have added my new module in the BOM

Checklist for adding new embedding store integration

  • I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT
  • I have added my new module in the BOM

Checklist for changing existing embedding store integration

  • I have manually verified that the {NameOfIntegration}EmbeddingStore works correctly with the data persisted using the latest released version of LangChain4j

Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wadimz thank you!

@langchain4j langchain4j merged commit ab8b1fa into langchain4j:main Jun 17, 2024
6 checks passed
@langchain4j
Copy link
Owner

Hi @Wadimz, both snapshot buildes are failing, seems to be right after this PR was merged:

Could you please check?

@langchain4j
Copy link
Owner

BTW I've added this: 071004b

@Wadimz
Copy link
Contributor Author

Wadimz commented Jun 19, 2024

Absolutely, checking

@Wadimz
Copy link
Contributor Author

Wadimz commented Jun 19, 2024

Suspicious that only this module started failing with 401.
[INFO] LangChain4j :: Experimental :: SQL ................. FAILURE [ 1.757 s]
Might it be some expired token here?

 Failed to execute goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.13:deploy (injected-nexus-deploy) on project ***-experimental-sql: Failed to deploy artifacts: Could not transfer artifact dev.***:***-pinecone:jar:sources:0.32.0-20240617.095335-57 from/to ossrh (https://s01.oss.sonatype.org/content/repositories/snapshots): authentication failed for https://s01.oss.sonatype.org/content/repositories/snapshots/dev/***/***-pinecone/0.32.0-SNAPSHOT/***-pinecone-0.32.0-20240617.095335-57-sources.jar, status: 401 Content access is protected by token -> [Help 1]

@langchain4j
Copy link
Owner

It seems to fail on the attempt to upload the first artifact

@langchain4j
Copy link
Owner

I guess I know the reason... Maven central are making changes to the OSSRH authentication backend. I will have to change the authentication from user/pwd to token.

Sorry for bothering you, I wrongly assumed that it is because of this PR due to the timing...

@Wadimz
Copy link
Contributor Author

Wadimz commented Jun 19, 2024

Thanks for quick investigation!

@Wadimz Wadimz deleted the do-not-run-jobs-on-forks branch June 20, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants