-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Nightly and release jobs should not be run on fork repositories #1302 #1303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wadimz thank you!
Hi @Wadimz, both snapshot buildes are failing, seems to be right after this PR was merged:
Could you please check? |
BTW I've added this: 071004b |
Absolutely, checking |
Suspicious that only this module started failing with 401.
|
It seems to fail on the attempt to upload the first artifact |
I guess I know the reason... Maven central are making changes to the OSSRH authentication backend. I will have to change the authentication from user/pwd to token. Sorry for bothering you, I wrongly assumed that it is because of this PR due to the timing... |
Thanks for quick investigation! |
This change addresses issue described in bug: [BUG] Nightly and release jobs should not be run on fork repositories #1302
Change was verified on fork using fork repository path.
Issue
#1302
Change
Change adds github job condition to be run only on the main project's repository.
General checklist
Checklist for adding new model integration
Checklist for adding new embedding store integration
{NameOfIntegration}EmbeddingStoreIT
that extends from eitherEmbeddingStoreIT
orEmbeddingStoreWithFilteringIT
Checklist for changing existing embedding store integration
{NameOfIntegration}EmbeddingStore
works correctly with the data persisted using the latest released version of LangChain4j