-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/metada with azure ai search #1291
base: main
Are you sure you want to change the base?
Conversation
Ping @jdubois |
e7e7b71
to
65a5874
Compare
@jdubois I've made a few changes to make it possible to create and use specific mapper implementations. |
@fb33 could you run it? :) |
I don't have the well configured environment for that... The IT in azure-ai-search module are not managed with TestContainer so I need to have the good env in my Azure subscription. |
@fb33 I've run it, unfortunately I'm getting errors, here's a screenshot |
|
Create a AzureAiSearchFilterMapper to manage azure filter query format. Signed-off-by: François Barbe <[email protected]> langchain4j#1263
Add a filter in the constructor. Switch from the deprecated method findRelevant to the new search method. EmbeddingSearchRequest allows to pass the filter to use. Signed-off-by: François Barbe <[email protected]> langchain4j#1263
create an interface to open the mapping to other structure of index. change static declaration to instance, and manage mapper with builders Signed-off-by: François Barbe <[email protected]> langchain4j#1263
Signed-off-by: François Barbe <[email protected]> langchain4j#1263
65a5874
to
fd06cf1
Compare
@jdubois It should be ok now. |
@fb33 I'm still getting 2 errors: DefaultAzureAiSearchFilterMapperTest.map_handlesComplexFilter()
And DefaultAzureAiSearchFilterMapperTest.map_handlesIsNotIn() :
|
Signed-off-by: François Barbe <[email protected]> langchain4j#1263
Sorry, I was focus on the IT test, I forgot to align my TU... It's done now. |
@langchain4j @jdubois, did this PR go to the right way for you ? |
@fb33 yes, I confirm all the tests pass on my side! |
Issue
#1263
Change
add a mapper of filter to azure ai search filter string base on the default index structure with metadata.
General checklist
Checklist for adding new model integration
Checklist for adding new embedding store integration
{NameOfIntegration}EmbeddingStoreIT
that extends from eitherEmbeddingStoreIT
orEmbeddingStoreWithFilteringIT
Checklist for changing existing embedding store integration
{NameOfIntegration}EmbeddingStore
works correctly with the data persisted using the latest released version of LangChain4j