Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AzureOpenAiStreamingChatModel constructor get or default new Tokenizer #1282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kugaaa
Copy link
Contributor

@Kugaaa Kugaaa commented Jun 13, 2024

Issue

no issue
I found during unit testing

Change

AzureOpenAiStreamingChatModel constructor get or default new Tokenizer
Referenced OpenAiStreamingChatModel

General checklist

  • There are no breaking changes
  • I have added unit and integration tests for my change
  • I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
  • I have manually run all the unit and integration tests in the core and main modules, and they are all green

Checklist for adding new model integration

  • I have added my new module in the BOM

Checklist for adding new embedding store integration

  • I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT
  • I have added my new module in the BOM

Checklist for changing existing embedding store integration

  • I have manually verified that the {NameOfIntegration}EmbeddingStore works correctly with the data persisted using the latest released version of LangChain4j

@pax95
Copy link

pax95 commented Jun 14, 2024

Found this too. Waiting for it to get merged

@langchain4j
Copy link
Owner

Thanks a lot! This change should probably be applied to ass Azure*Model classes?

cc @agoncal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants