-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 1266 Allow using streaming AI Service with tools without memory #1280
Conversation
…I Service with tools without memory
… without memory UT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kugaaa thank you!
This does not seem to work as expected, I can see that should_use_tool_without_memory
is failing for the second model (Mistral).
For OpenAI, it does not work properly as well:
In the first request, user message is sent.
In the second request, only assistant and tool messages are sent (user message is not sent, but should be).
langchain4j/src/test/java/dev/langchain4j/service/StreamingAiServicesWithToolsIT.java
Outdated
Show resolved
Hide resolved
I'll check again |
…erviceOnStart start
… without memory UT in StreamingAiServicesWithToolsWithoutMemoryIT
…estBuilder to ConcurrentHashMap
...ain4j-open-ai/src/main/java/dev/langchain4j/model/openai/OpenAiStreamingResponseBuilder.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kugaaa thank you!
Issue
See #1266
Change
General checklist
Checklist for adding new model integration
Checklist for adding new embedding store integration
{NameOfIntegration}EmbeddingStoreIT
that extends from eitherEmbeddingStoreIT
orEmbeddingStoreWithFilteringIT
Checklist for changing existing embedding store integration
{NameOfIntegration}EmbeddingStore
works correctly with the data persisted using the latest released version of LangChain4j