Add docusaurus-lunr-search plugin #1221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LizeRaes
added a commit
that referenced
this pull request
Jun 11, 2024
Well, well, I'm not a front-end guy and therefore not super confortable with NPM and Node. I've updated Docusaurus so it runs the latest version and to see if I can add search and single-page to the documentation. Hope this runs on CI/CD Also see #1221 Co-authored-by: Lize Raes <[email protected]>
jiangsier-xyz
pushed a commit
to jiangsier-xyz/langchain4j
that referenced
this pull request
Jun 11, 2024
Well, well, I'm not a front-end guy and therefore not super confortable with NPM and Node. I've updated Docusaurus so it runs the latest version and to see if I can add search and single-page to the documentation. Hope this runs on CI/CD Also see langchain4j#1221 Co-authored-by: Lize Raes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1219
Change
Added the
docusaurus-lunr-searchplugin.It may seem that for search feature we would need a server. But nothing stops us from passing that logic to the client)
So, if the index for pages is not too big, we will delegate the search functionality to client. That's what this plugin does (I think).
It works with
npm run serve, but I couldn't test it with just opening theindex.htmlfile.Oh, I'm sorry, my editor autoformatted the file)
General checklist