feat(nodejs): feature parity [2/N] - add table.name and lancedb.connect({args})
#1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
universalmind303
changed the title
table.name and lancedb.connect({args})table.name and lancedb.connect({args})
|
ACTION NEEDED Lance follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
universalmind303
changed the title
table.name and lancedb.connect({args})table.name and lancedb.connect({args})
wjones127
reviewed
Jun 17, 2024
wjones127
approved these changes
Jun 21, 2024
universalmind303
added a commit
that referenced
this pull request
Jun 21, 2024
…ions})` (#1386) adds support for the `vectordb` syntax of `createTable({name, data, ...options})`. depends on #1380 see actual diff here universalmind303/lancedb@table-name...universalmind303:create-table-args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1378
see proper diff here universalmind303/lancedb@remote-table-node...universalmind303:lancedb:table-name