Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nodejs): table.indexStats #1361

Merged
merged 24 commits into from
Jun 21, 2024
Merged

feat(nodejs): table.indexStats #1361

merged 24 commits into from
Jun 21, 2024

Conversation

universalmind303
Copy link
Contributor

closes #1359

@github-actions github-actions bot added enhancement New feature or request Rust Rust related issues labels Jun 6, 2024
@universalmind303 universalmind303 added the typescript Typescript / javascript label Jun 6, 2024
wjones127
wjones127 requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't point this out earlier, but the existing APIs are flawed and need to be fixed soon. See my comment on using name over uuid.

nodejs/src/table.rs Outdated Show resolved Hide resolved
nodejs/lancedb/table.ts Outdated Show resolved Hide resolved
nodejs/src/table.rs Show resolved Hide resolved
wjones127
wjones127 reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on the docs.

nodejs/lancedb/table.ts Outdated Show resolved Hide resolved
@universalmind303
Copy link
Contributor Author

@wjones127 the failure is unrelated. I opened up an issue for it here

@universalmind303 universalmind303 merged commit 55f8834 into lancedb:main Jun 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjones127 wjones127 wjones127 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Rust Rust related issues typescript Typescript / javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nodejs: Table.indexStats() in @lancedb
2 participants
@universalmind303 @wjones127