-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(java): build JNI release package #2516
base: main
Are you sure you want to change the base?
Conversation
70fca48
to
12303fd
Compare
#2524
the created jar can be used without the glibc issue |
- .github/workflows/java-publish.yml | ||
|
||
jobs: | ||
macos-arm64: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i felt like it should not be 3 jobs. but instead we should have 3 run matrix and at the very end we need to copy all 3 share lib (linux-x86, linux-arm, macos-arm) into the same fat jar?
this will still release 3 different JAR IIUC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, if we call mvn deploy
in three different job, we have to release 3 different jars (with different names?).
I am not sure that mvn will resolve dependency based on the system, like what pypi does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should have 3 run matrix and at the very end we need to copy all 3 share lib (linux-x86, linux-arm, macos-arm) into the same fat jar?
Put them into separate jobs, so that i can pass upload-artifcat/download-artifcat
between the jobs. If we just run 3 parallel metrics, we need the 4th one to download the artifact?
Provide a Github action workflow to release multi-platform JNI