Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(java): build JNI release package #2516

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Jun 24, 2024

Provide a Github action workflow to release multi-platform JNI

@github-actions github-actions bot added ci Github Action or Test issues java labels Jun 24, 2024
@eddyxu eddyxu changed the title ci: build JNI release package ci(java): build JNI release package Jun 24, 2024
@eddyxu eddyxu requested a review from LuQQiu June 24, 2024 18:22
@eddyxu eddyxu marked this pull request as ready for review June 24, 2024 20:05
@LuQQiu
Copy link
Collaborator

LuQQiu commented Jun 26, 2024

#2524
After add an extra step to set up nodejs 16 instead of default 20

      - name: Set up Node.js 16
        uses: actions/setup-node@v4
        with:
          node-version: '16'

the created jar can be used without the glibc issue
validated in linux x86 ubuntu 22 spark job

- .github/workflows/java-publish.yml

jobs:
macos-arm64:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i felt like it should not be 3 jobs. but instead we should have 3 run matrix and at the very end we need to copy all 3 share lib (linux-x86, linux-arm, macos-arm) into the same fat jar?

this will still release 3 different JAR IIUC?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, if we call mvn deploy in three different job, we have to release 3 different jars (with different names?).
I am not sure that mvn will resolve dependency based on the system, like what pypi does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have 3 run matrix and at the very end we need to copy all 3 share lib (linux-x86, linux-arm, macos-arm) into the same fat jar?

Put them into separate jobs, so that i can pass upload-artifcat/download-artifcat between the jobs. If we just run 3 parallel metrics, we need the 4th one to download the artifact?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Github Action or Test issues java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants