Add DomainName field to AdminNetworkPolicyEgressPeer #233
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rahulkjoshi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @rahulkjoshi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -196,6 +196,21 @@ type AdminNetworkPolicyEgressPeer struct { | |||
| // +kubebuilder:validation:MinItems=1 | |||
| // +kubebuilder:validation:MaxItems=25 | |||
| Networks []CIDR `json:"networks,omitempty"` | |||
|
|
|||
There was a problem hiding this comment.
I think we'll have to unfortunately :/ @tssurya can chime in if there's another way since she implemented it in the first place
I dont think it's too big of a deal though, we would just move the EgressPeer typedef out of shared_types.go
There was a problem hiding this comment.
@rahulkjoshi You should be good to go ahead and make this change :)
| // "wikipedia.org" do not. | ||
| // | ||
| // +kubebuilder:validation:Pattern=`^(\*\.)?([a-zA-z0-9]([-a-zA-Z0-9_]*[a-zA-Z0-9])?\.)+[a-zA-z0-9]([-a-zA-Z0-9_]*[a-zA-Z0-9])?\.?$` | ||
| type DomainName string |
| // <network-policy-api:experimental> | ||
| // +optional | ||
| // +listType=set | ||
| // +kubebuilder:validation:MinItems=1 |
| @@ -196,6 +196,21 @@ type AdminNetworkPolicyEgressPeer struct { | |||
| // +kubebuilder:validation:MinItems=1 | |||
| // +kubebuilder:validation:MaxItems=25 | |||
| Networks []CIDR `json:"networks,omitempty"` | |||
|
|
|||
There was a problem hiding this comment.
I think we'll have to unfortunately :/ @tssurya can chime in if there's another way since she implemented it in the first place
I dont think it's too big of a deal though, we would just move the EgressPeer typedef out of shared_types.go
#133