Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kjobctl] Add interactive builder #2480

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[kjobctl] Add interactive builder #2480

wants to merge 3 commits into from

Conversation

IrvingMg
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add interactive builder for kjobctl.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: IrvingMg
Once this PR has been reviewed and has the lgtm label, please assign trasc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 26, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 26, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 9a60467
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/667d3cd8d1f6b0000894cbd2

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2024
@IrvingMg IrvingMg force-pushed the feature/kjobctl-interactive-builder branch from 66eb36d to 1c94a87 Compare June 26, 2024 12:04
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 26, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2024
@IrvingMg IrvingMg force-pushed the feature/kjobctl-interactive-builder branch from 00a151a to 9a60467 Compare June 27, 2024 10:20
trasc
trasc reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 778d60c88c4c8d2867baf4d7987635d0fed67772

@alculquicondor
Copy link
Contributor

/assign @mwielgus

@mbobrovskyi
Copy link
Contributor

lgtm

@IrvingMg IrvingMg marked this pull request as ready for review June 28, 2024 07:57
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from trasc June 28, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@trasc trasc Awaiting requested review from trasc

Assignees

@mwielgus mwielgus

@trasc trasc

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@IrvingMg @k8s-ci-robot @alculquicondor @mbobrovskyi @trasc @mwielgus