-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: rework pipeline: short/extended based on labels #11324
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ant31 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
acfeded
to
f3239e7
Compare
f3239e7
to
f67654d
Compare
/retest |
Hey! This kind of approach seems quite sensible to me, but what the policy should be here? Any code change we put the extended test (meaning not a doc only change for instance)? Or is it depending on if the reviewers (as of the persons who is reviewing a PR not the role reviewer on the repo) of a PR think it needs the extended test or not? Also the kubespray reviewers who are not approvers can't edit labels I believe or maybe that would be just me, not sure 🤷♂️. |
@MrFreezeex it introduces the mechanism to do it. How it is used is up for discussion and the threasold can move easily. Which label trigger what can be changed too. In this PR the default pipeline is close to the previous one (removed few redundant test imo) so it's not a big change.
About applying labels, yes it would be the role of the reviewer to determine it. PR owner could self assess too. |
Beside the labels, important change is that there's no more stages, but job dependencies. As a result, those new pipelines runs in ~25min. https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/pipelines/1347530306 |
This is needed to use the new infrastructure, should make CI go through faster, and hopefully improve contributors' experiences. The main blocking point could be the job that runs by default. I tried to remove from the default pipeline only a few:
I go for:
We can still run full tests on schedule (daily) and for tags/releases, but not on every PR. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #8786
Special notes for your reviewer:
Does this PR introduce a user-facing change?: